fix(Test Starter Configs): Fix false-positive findings #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
reviewed
Nov 15, 2024
test/fixtures/linter/rules/NoDeprecatedApi/Configuration.beforeBootstrap.qunit.js
Outdated
Show resolved
Hide resolved
matz3
approved these changes
Nov 15, 2024
Merged
maxreichmann
added a commit
that referenced
this pull request
Nov 15, 2024
This fixes a false-positive finding of the property `theme` inside `Configuration.beforeBootstrap.qunit.js`[^1] [^1]: https://github.com/SAP/openui5/blob/master/src/sap.ui.core/test/sap/ui/core/qunit/bootstrap/Configuration.beforeBootstrap.qunit.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a false-positive finding of the property
themeinside Configuration.beforeBootstrap.qunit.js. This resulted in undefined runtime errors.themeshould only be checked for Test Starter configs.Changes:
Now, the file name is checked against a Regex and optional chaining was optimized to prevent these runtime errors further.
A sample
Configuration.beforeBootstrap.qunit.jswas added as a test artifact. As seen in the snapshots, there are no more findings for this file.In the course of adding a Regex check for the file name,
testsuite2.qunit.jswas renamed totestsuite.special-case-quotes.qunit.jsto be aligned with framework functionality.