Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ThemeProvider): create own style tag containing css variables #121

Merged
merged 5 commits into from
Sep 16, 2019

Conversation

vbersch
Copy link
Contributor

@vbersch vbersch commented Sep 16, 2019

create own style tag containing css variables to avoid race conditions with ui5 webcomponents css variables style tag

…Frame so that it won´t interfere with style tag initialization
# Conflicts:
#	packages/main/src/components/ThemeProvider/index.tsx
@netlify
Copy link

netlify bot commented Sep 16, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit 268b28c

https://deploy-preview-121--ui5-webcomponents-react.netlify.com

Copy link
Contributor

@MarcusNotheis MarcusNotheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should clear the textContent of the style[data-ui5-webcomponents-react-theme-properties] node in case the theme is not sap_fiori_3. Otherwise we will always overwrite the sap_belize and other themes with the fiori 3 variables.

@MarcusNotheis MarcusNotheis merged commit 19d8cff into master Sep 16, 2019
@MarcusNotheis MarcusNotheis deleted the fix/css-vars branch September 16, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants