-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(framework): Clean up legacy code and improve bundle size #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Removed `KeyCodes` export from `base`, please use `event.key` instead BREAKING CHANGE: Removed `pushElementBackInScreen` from `base`
BREAKING CHANGE: `base`: Removed fonts exports, please use parameters instead
Deploy preview for ui5-webcomponents-react ready! Built with commit c9f2f36 https://deploy-preview-135--ui5-webcomponents-react.netlify.com |
MarcusNotheis
changed the title
Chore/framework clean up
refactor(framework): Clean up legacy code and improve bundle size
Sep 23, 2019
vbersch
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
lib
exports for for better bundle sizereact-jss
tov10.0.0
withChartContainer
lib export for better bundle sizeBreaking Changes
KeyCodes
export frombase
, please useevent.key
insteadpushElementBackInScreen
frombase
fonts
exports, please use parameters instead