Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(withWebComponent): Bind unknown events & cleanup #182

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

MarcusNotheis
Copy link
Contributor

BREAKING CHANGE:

Removed innerStyles prop in favour of css variables and UI5's addCustomCSS API

Fixes #181

BREAKING CHANGE: Removed `innerStyles` prop in favor of css variables and UI5's `addCustomCSS` API

Fixes #181
@MarcusNotheis MarcusNotheis requested a review from vbersch October 10, 2019 10:37
@codecov-io
Copy link

Codecov Report

Merging #182 into master will increase coverage by 0.22%.
The diff coverage is 83.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   74.41%   74.64%   +0.22%     
==========================================
  Files         148      148              
  Lines        3389     3380       -9     
  Branches      594      592       -2     
==========================================
+ Hits         2522     2523       +1     
+ Misses        664      650      -14     
- Partials      203      207       +4
Impacted Files Coverage Δ
packages/main/src/internal/withWebComponent.tsx 79.79% <83.87%> (+7.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ad0c0...ee1b2ae. Read the comment docs.

@MarcusNotheis MarcusNotheis merged commit b6e2a66 into master Oct 10, 2019
@MarcusNotheis MarcusNotheis deleted the fix/181 branch October 10, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog: Events not fired
3 participants