Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ObjecPage): fix scrollbar width on windows #188

Merged
merged 7 commits into from
Oct 17, 2019

Conversation

vbersch
Copy link
Contributor

@vbersch vbersch commented Oct 17, 2019

No description provided.

@vbersch vbersch requested a review from MarcusNotheis October 17, 2019 05:50
@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #188 into master will decrease coverage by 0.41%.
The diff coverage is 20.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   74.09%   73.67%   -0.42%     
==========================================
  Files         150      150              
  Lines        3470     3499      +29     
  Branches      615      617       +2     
==========================================
+ Hits         2571     2578       +7     
- Misses        686      708      +22     
  Partials      213      213
Impacted Files Coverage Δ
packages/base/src/utils/index.ts 8% <4.76%> (+8%) ⬆️
packages/main/src/components/ObjectPage/index.tsx 45.93% <62.5%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105c7e1...e9f24bd. Read the comment docs.

Co-Authored-By: Marcus Notheis <MarcusNotheis@users.noreply.github.com>
@vbersch vbersch merged commit 8af1a4c into master Oct 17, 2019
@vbersch vbersch deleted the fix/objectPage-windows branch October 17, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants