-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AnalyticalTable): Add onRowExpandChange prop and placeholder loading #207
Conversation
BREAKING CHANGE: Removed unused prop `cellHeight`, use `rowHeight` instead BREAKING CHANGE: Removed unused prop `reactTableProps` BREAKING CHANGE: Removed unused prop `getTableProps` BREAKING CHANGE: Removed unused prop `getHeaderGroupsProps` BREAKING CHANGE: Removed unused prop `getHeaderProps` BREAKING CHANGE: Removed unused prop `getRowProps` BREAKING CHANGE: Removed unused prop `getCellProps`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/main/src/components/AnalyticalTable/defaults/NoDataComponent/index.tsx
Outdated
Show resolved
Hide resolved
packages/main/src/components/AnalyticalTable/demo/demo.stories.tsx
Outdated
Show resolved
Hide resolved
packages/main/src/components/AnalyticalTable/hooks/useRowSelection.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 73.65% 73.23% -0.42%
==========================================
Files 150 154 +4
Lines 3530 3572 +42
Branches 625 631 +6
==========================================
+ Hits 2600 2616 +16
- Misses 713 736 +23
- Partials 217 220 +3
Continue to review full report at Codecov.
|
BREAKING CHANGES
cellHeight
, userowHeight
insteadreactTableProps
getTableProps
getHeaderGroupsProps
getHeaderProps
getRowProps
getCellProps