Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AnalyticalTable): Add onRowExpandChange prop and placeholder loading #207

Merged
merged 11 commits into from
Oct 28, 2019

Conversation

MarcusNotheis
Copy link
Contributor

BREAKING CHANGES

  • Removed unused prop cellHeight, use rowHeight instead
  • Removed unused prop reactTableProps
  • Removed unused prop getTableProps
  • Removed unused prop getHeaderGroupsProps
  • Removed unused prop getHeaderProps
  • Removed unused prop getRowProps
  • Removed unused prop getCellProps

BREAKING CHANGE: Removed unused prop `cellHeight`, use `rowHeight` instead
BREAKING CHANGE: Removed unused prop `reactTableProps`
BREAKING CHANGE: Removed unused prop `getTableProps`
BREAKING CHANGE: Removed unused prop `getHeaderGroupsProps`
BREAKING CHANGE: Removed unused prop `getHeaderProps`
BREAKING CHANGE: Removed unused prop `getRowProps`
BREAKING CHANGE: Removed unused prop `getCellProps`
@MarcusNotheis MarcusNotheis requested a review from vbersch October 25, 2019 13:29
Copy link
Contributor

@vbersch vbersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing visibleRows prop does nothing

image

@codecov-io
Copy link

codecov-io commented Oct 25, 2019

Codecov Report

Merging #207 into master will decrease coverage by 0.41%.
The diff coverage is 54.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   73.65%   73.23%   -0.42%     
==========================================
  Files         150      154       +4     
  Lines        3530     3572      +42     
  Branches      625      631       +6     
==========================================
+ Hits         2600     2616      +16     
- Misses        713      736      +23     
- Partials      217      220       +3
Impacted Files Coverage Δ
.../components/AnalyticalTable/ColumnHeader/index.tsx 68% <ø> (ø) ⬆️
...omponents/AnalyticalTable/ColumnHeader/Resizer.tsx 42.85% <ø> (ø)
...AnalyticalTable/defaults/FilterComponent/index.tsx 75% <ø> (ø)
...omponents/AnalyticalTable/hooks/useRowSelection.ts 31.81% <ø> (ø) ⬆️
...omponents/AnalyticalTable/hooks/useTableStyling.ts 100% <100%> (ø) ⬆️
...nents/AnalyticalTable/hooks/useTableCellStyling.ts 100% <100%> (ø) ⬆️
...onents/AnalyticalTable/hooks/useTableRowStyling.ts 56.66% <100%> (ø) ⬆️
...ble/defaults/LoadingComponent/TablePlaceholder.tsx 23.52% <23.52%> (ø)
...nalyticalTable/defaults/LoadingComponent/index.tsx 28.57% <28.57%> (ø)
...components/AnalyticalTable/hooks/useCellStyling.ts 23.07% <33.33%> (+1.33%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe50a43...e84bb7c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants