feat(ObjectPage): Enable selecting a subSection by prop #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ui5-webcomponents-react ready! Built with commit df4cdc5 https://deploy-preview-213--ui5-webcomponents-react.netlify.com |
Lukas742
reviewed
Oct 31, 2019
| } | ||
| } | ||
| } | ||
| }, [props.selectedSubSectionId, scroller.current, setSelectedSectionIndex, setSelectedSubSectionId]); |
There was a problem hiding this comment.
Add mode and children to dependency array
Lukas742
approved these changes
Oct 31, 2019
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
========================================
+ Coverage 73.7% 74% +0.29%
========================================
Files 156 155 -1
Lines 3605 3600 -5
Branches 637 633 -4
========================================
+ Hits 2657 2664 +7
+ Misses 730 717 -13
- Partials 218 219 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectedSubSectionId: Enable selecting a subSection by prop
scrollerRef: get a reference to the internal scroller object to be able to make the ObjectPage scroll to arbitrary dom elements