Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SegmentedButton): call onClick prop on SegmentedButtonItem if set #218

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

vbersch
Copy link
Contributor

@vbersch vbersch commented Nov 7, 2019

No description provided.

@vbersch vbersch requested a review from MarcusNotheis November 7, 2019 09:12
@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #218 into master will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   73.99%   73.96%   -0.04%     
==========================================
  Files         156      156              
  Lines        3615     3618       +3     
  Branches      638      639       +1     
==========================================
+ Hits         2675     2676       +1     
- Misses        719      720       +1     
- Partials      221      222       +1
Impacted Files Coverage Δ
...ages/main/src/components/SegmentedButton/index.tsx 54.34% <33.33%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d1069...0d92f4e. Read the comment docs.

@vbersch vbersch merged commit bc9bef3 into master Nov 7, 2019
@vbersch vbersch deleted the fix/seg-button-item-onclick branch November 7, 2019 09:28
@netlify
Copy link

netlify bot commented Nov 7, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit 0d92f4e

https://deploy-preview-218--ui5-webcomponents-react.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants