feat(WebComponents): Update to v1.0.0-rc.5 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Icon import paths changed from `@ui5/webcomponents/dist/icons/add.js` to `@ui5/webcomponents-icons/dist/icons/add.js`. BREAKING CHANGE: **Icon**: prop `src` was renamed to `name` BREAKING CHANGE: **Icon**: the `sap-icon://` prefix was removed BREAKING CHANGE: **ShellBar** prop `icon` was renamed to `startButton` BREAKING CHANGE: **ShellBarItem**: prop `src` was renamed to `name` BREAKING CHANGE: **Card**: `avatar` prop now accepts a node instead of a string Please also check the [UI5 Web Components Release Notes](https://github.com/SAP/ui5-webcomponents/releases/tag/v1.0.0-rc.5)
|
Deploy preview for ui5-webcomponents-react ready! Built with commit 9df3f8c https://deploy-preview-236--ui5-webcomponents-react.netlify.com |
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=========================================
+ Coverage 72.25% 72.3% +0.04%
=========================================
Files 160 162 +2
Lines 3532 3538 +6
Branches 615 615
=========================================
+ Hits 2552 2558 +6
Misses 756 756
Partials 224 224
Continue to review full report at Codecov.
|
vbersch
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Icon import paths changed from
@ui5/webcomponents/dist/icons/add.jsto@ui5/webcomponents-icons/dist/icons/add.js.BREAKING CHANGE: Icon: prop
srcwas renamed tonameBREAKING CHANGE: Icon: the
sap-icon://prefix was removedBREAKING CHANGE: ShellBar prop
iconwas renamed tostartButtonBREAKING CHANGE: ShellBarItem: prop
srcwas renamed tonameBREAKING CHANGE: Card:
avatarprop now accepts a node instead of a stringPlease also check the UI5 Web Components Release Notes
Closes #202