Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(AnalyticalTable): update react-table and replace grid with absolute layout #238

Merged
merged 8 commits into from
Dec 9, 2019

Conversation

MarcusNotheis
Copy link
Contributor

@MarcusNotheis MarcusNotheis commented Dec 4, 2019

BREAKING CHANGE: Update react-table to 7.0.0-rc.5

… with absolute layout

BREAKING CHANGE: Update `react-table` to `7.0.0-rc.23`
@MarcusNotheis MarcusNotheis requested a review from vbersch December 4, 2019 14:11
@netlify
Copy link

netlify bot commented Dec 4, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit 529ac00

https://deploy-preview-238--ui5-webcomponents-react.netlify.com

@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #238 into master will increase coverage by 0.04%.
The diff coverage is 65.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   72.46%   72.51%   +0.04%     
==========================================
  Files         163      159       -4     
  Lines        3519     3467      -52     
  Branches      609      603       -6     
==========================================
- Hits         2550     2514      -36     
+ Misses        749      745       -4     
+ Partials      220      208      -12
Impacted Files Coverage Δ
...nalyticalTable/virtualization/VirtualTableBody.tsx 81.81% <ø> (+14.07%) ⬆️
...main/src/components/AnalyticalTable/hooks/utils.ts 0% <0%> (-40%) ⬇️
...nents/AnalyticalTable/tableReducer/stateReducer.ts 100% <100%> (ø)
...AnalyticalTable/virtualization/VirtualTableRow.tsx 63.63% <100%> (-1.59%) ⬇️
...mponents/AnalyticalTable/defaults/Column/index.tsx 60% <100%> (ø) ⬆️
...AnalyticalTable/defaults/FilterComponent/index.tsx 75% <100%> (ø) ⬆️
...omponents/AnalyticalTable/hooks/useTableStyling.ts 100% <100%> (ø) ⬆️
...nts/AnalyticalTable/hooks/useTableHeaderStyling.ts 100% <100%> (ø) ⬆️
...nalyticalTable/hooks/useTableHeaderGroupStyling.ts 100% <100%> (ø) ⬆️
...components/AnalyticalTable/hooks/useDragAndDrop.ts 33.33% <20%> (-33.34%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22729e2...529ac00. Read the comment docs.

@MarcusNotheis MarcusNotheis merged commit e9bc297 into master Dec 9, 2019
@MarcusNotheis MarcusNotheis deleted the refactor/AnalyticalTable branch December 9, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants