Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge on ShellBarItem #299

Closed
vinniimiranda opened this issue Feb 4, 2020 · 6 comments
Closed

Badge on ShellBarItem #299

vinniimiranda opened this issue Feb 4, 2020 · 6 comments

Comments

@vinniimiranda
Copy link

Hello, i am using this library to build an application similar of a e-commerce.

The problem is that i wat to show the amount"products" there are in the cart, but for this i need to display the number side to the ShellBarItem, which is not possible at the moment.

So i would like to ask if you guys can help with that.

Here's an example of the code:
<ShellBarItem icon="download" onItemClick={() => history.push("/box")} />

It would be nice if we can pass an number and this value be displaied side to the icon, like this:
<ShellBarItem icon="download" amount={10} onItemClick={() => history.push("/box")} />

@MarcusNotheis
Copy link
Contributor

Hi @vinniimiranda - thanks for submitting this issue.
As the ShellBarItem is a UI5 Web Component and not 'directly' built by us I have opened a corresponding issue for the UI5 Web Components Project: SAP/ui5-webcomponents#1177

@vinniimiranda
Copy link
Author

Thanks, i'll be waiting.

@vinniimiranda
Copy link
Author

Hi!

They already have implemented this feature on UI5 Web Component.

@MarcusNotheis
Copy link
Contributor

Hey :) yes, they merged it yesterday and as soon as they release their next rc we are going to update as well

@vinniimiranda
Copy link
Author

Sure, thanks a lot!

@MarcusNotheis
Copy link
Contributor

Released in 0.9.0-rc.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants