Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AnalyticalTable): add infiniteScroll and keyboard navigation for cells #397

Merged
merged 9 commits into from
Apr 3, 2020

Conversation

MarcusNotheis
Copy link
Contributor

@MarcusNotheis MarcusNotheis commented Apr 1, 2020

BREAKING CHANGE: column option groupable replaced by disableGroupBy: boolean
BREAKING CHANGE: column option sortable replaced by disableSortBy: boolean
BREAKING CHANGE: column option filterable replaced by disableFilters: boolean
BREAKING CHANGE: Enabling grouping, sorting or filtering on column level by e.g disableGroupBy: false will not overwrite the table overall setting in case e.g. groupable={false}

…le properties

BREAKING CHANGE: column option `groupable` replaced by `disableGroupBy`
BREAKING CHANGE: column option `sortable` replaced by `disableSortBy`
BREAKING CHANGE: column option `filterable` replaced by `disableFilters`
BREAKING CHANGE: Enabling grouping, sorting or filtering by e.g `disableGroupBy: false` will not overwrite the table overall setting in case e.g. `groupable={false}`
@MarcusNotheis MarcusNotheis requested a review from vbersch April 1, 2020 10:32
@netlify
Copy link

netlify bot commented Apr 1, 2020

Deploy preview for ui5-webcomponents-react ready!

Built with commit 0a93302

https://deploy-preview-397--ui5-webcomponents-react.netlify.com

@github-actions
Copy link

github-actions bot commented Apr 1, 2020

Coverage Status

Coverage decreased (-0.8%) to 68.865% when pulling a892b82 on refactor/table into fb282c7 on master.

@MarcusNotheis MarcusNotheis changed the title feat(AnalyticalTable): enable keyboard navigation for cells & remove custom props feat(AnalyticalTable): add infiniteScroll and keyboard navigation for cells Apr 1, 2020
@MarcusNotheis MarcusNotheis requested a review from Lukas742 April 2, 2020 15:08
@MarcusNotheis MarcusNotheis merged commit c6b64ba into master Apr 3, 2020
@MarcusNotheis MarcusNotheis deleted the refactor/table branch April 3, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants