Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form: FormItems does not have a consistent width #553

Closed
mathlizee opened this issue May 30, 2020 · 3 comments
Closed

Form: FormItems does not have a consistent width #553

mathlizee opened this issue May 30, 2020 · 3 comments

Comments

@mathlizee
Copy link

Hello,

I'm currently using a form that is similar to this one. As you can see, the FormItem inside my Form do not have a consistent width. Would it be possible for all FormItem to have the maximum width available or, at least, to have a consistent overall width? It would be even nicer if there was a property to set the FormItem's width according to the screen size (S, M, ...)

I'm using version 0.10.0-rc.1 of the library with Chrome.

Thanks!
Mathieu

@mathlizee mathlizee added the bug label May 30, 2020
@MarcusNotheis
Copy link
Contributor

Hi @mathlizee,

I'm not sure if I understand the issue to 100%. As far as I can see in your code-sandbox, all FormItems using the maximum available width. The inner elements like Input, ComboBox, TextArea etc. all don't have a default width.
I think the easiest solution would we creating a style class like fullWidth (with width: 100%) and assign them to the individual elements.

Does that work for you?

@mathlizee
Copy link
Author

Hi @MarcusNotheis,

I feel a bit dumb not thinking about this before creating the issue! I modified my code sample to use width: 100% in the controls. It seems to work fine except for the TimePicker control, which doesn't seem to have the full width.

Could it be fixed?

Thanks again!
Mathieu

@MarcusNotheis
Copy link
Contributor

MarcusNotheis commented Jun 6, 2020

Hi @mathlizee,
no worries :) Yes, the TimePicker should definitely be fixed - therefore I'll close this issue here and I've created a new issue on the UI5 Web Components repo for fixing this: SAP/ui5-webcomponents#1738

Best regards,
Marcus

EDIT: Seems to be already fixed on the next release of UI Web Components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants