Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ObjectPage): Highlight selected section #56

Merged
merged 7 commits into from
Jul 12, 2019
Merged

fix(ObjectPage): Highlight selected section #56

merged 7 commits into from
Jul 12, 2019

Conversation

MarcusNotheis
Copy link
Contributor

  • Highlight the selected Section on scroll
  • Add noHeader prop

@MarcusNotheis MarcusNotheis requested a review from vbersch July 12, 2019 11:51
vbersch
vbersch requested changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@vbersch vbersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when noHeader is set to true, its impossible to select the last section, no matter how far you scroll.

packages/main/package.json Outdated Show resolved Hide resolved
packages/main/src/components/ObjectPage/index.tsx Outdated Show resolved Hide resolved
@MarcusNotheis
Copy link
Contributor Author

Scrolling to the bottom of the last section is now working in noHeader mode as well.

@MarcusNotheis MarcusNotheis merged commit 42a6a10 into master Jul 12, 2019
@MarcusNotheis MarcusNotheis deleted the fix/ObjectPage branch July 12, 2019 13:11
MarcusNotheis pushed a commit that referenced this pull request Oct 21, 2020
@LuisValgoi @MarcusNotheis
Merge pull request #56 from LuisValgoi/issue-44
7a4ec0c 
[ISSUE-44] Refactor .envs for Scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbersch vbersch vbersch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcusNotheis @vbersch