Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Customize Donut Chart Hover Label Formatter #613

Closed
eeshamoona opened this issue Jul 20, 2020 · 4 comments · Fixed by #614
Closed

Unable to Customize Donut Chart Hover Label Formatter #613

eeshamoona opened this issue Jul 20, 2020 · 4 comments · Fixed by #614

Comments

@eeshamoona
Copy link

Trying to reproduce this example where the formatter changes the labels in the legend AND in the on hover label on the donut chart. When trying to reproduce the formatter only changes the labels in the legend.

Using the latest version of ui5 web-components react charts: 0.9.9

https://sap.github.io/ui5-webcomponents-react/?path=/docs/charts-donutchart--with-formatter#with-formatter
Screen Shot 2020-07-20 at 10 36 41 AM

@Lukas742
Copy link
Contributor

Lukas742 commented Jul 21, 2020

Hi @eeshamoona

Could you try updating @ui5/webcomponents-react-charts to our latest rc (0.10.0-rc.7)? This should solve the issue.

@eeshamoona
Copy link
Author

Updated version to 0.10.0-rc.7 and the issue still persists.

@Lukas742 Lukas742 linked a pull request Jul 22, 2020 that will close this issue
2 tasks
@Lukas742
Copy link
Contributor

I opened a PR that should fix the issue. The formatter was only applied to the Tooltip if the dimension accessor was name. That's why it was hard for me to detect this issue in the beginning because we are using name as accessor in our demo.

We will let you know when this is released.

@MarcusNotheis
Copy link
Contributor

Released in @ui5/webcomponents-react-charts@0.10.0-rc.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants