From ac2408548946c885ce53cb4134a32bd9a9398210 Mon Sep 17 00:00:00 2001 From: "Harbarth, Lukas" Date: Thu, 14 Nov 2019 13:17:17 +0100 Subject: [PATCH 1/3] fix(Text): Added default width of '100%' so ellipsis is shown if text is overflowing --- packages/main/src/components/Text/demo.stories.tsx | 2 +- packages/main/src/components/Text/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/main/src/components/Text/demo.stories.tsx b/packages/main/src/components/Text/demo.stories.tsx index b33766d11ff..44b21ae2d0b 100644 --- a/packages/main/src/components/Text/demo.stories.tsx +++ b/packages/main/src/components/Text/demo.stories.tsx @@ -8,7 +8,7 @@ export const renderStory = () => { Lorem ipsum dolor st amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. diff --git a/packages/main/src/components/Text/index.tsx b/packages/main/src/components/Text/index.tsx index 913eb066dbf..51ccaa69d58 100644 --- a/packages/main/src/components/Text/index.tsx +++ b/packages/main/src/components/Text/index.tsx @@ -52,7 +52,7 @@ const Text: FC = forwardRef((props: TextProps, ref: Ref Date: Thu, 14 Nov 2019 13:33:02 +0100 Subject: [PATCH 2/3] fix(Text): Updated snapshots --- .../AnalyticalCard.test.tsx.snap | 1 + .../__snapshots__/MessageBox.test.tsx.snap | 10 ++++++++++ .../__snapshots__/Notification.test.tsx.snap | 5 +++++ .../NotificationGroup.test.tsx.snap | 15 ++++++++++++++ .../__snapshots__/ObjectPage.test.tsx.snap | 9 +++++++++ .../SideNavigation.test.tsx.snap | 20 +++++++++++++++++++ .../Text/__snapshots__/Text.test.tsx.snap | 3 +++ 7 files changed, 63 insertions(+) diff --git a/packages/main/src/components/AnalyticalCard/__snapshots__/AnalyticalCard.test.tsx.snap b/packages/main/src/components/AnalyticalCard/__snapshots__/AnalyticalCard.test.tsx.snap index bebd30b9a92..f16aa03784d 100644 --- a/packages/main/src/components/AnalyticalCard/__snapshots__/AnalyticalCard.test.tsx.snap +++ b/packages/main/src/components/AnalyticalCard/__snapshots__/AnalyticalCard.test.tsx.snap @@ -101,6 +101,7 @@ exports[`Analytical Card Render without Crashing 1`] = ` > I'm a content! diff --git a/packages/main/src/components/MessageBox/__snapshots__/MessageBox.test.tsx.snap b/packages/main/src/components/MessageBox/__snapshots__/MessageBox.test.tsx.snap index 15281cd07d7..52cc9d55c86 100644 --- a/packages/main/src/components/MessageBox/__snapshots__/MessageBox.test.tsx.snap +++ b/packages/main/src/components/MessageBox/__snapshots__/MessageBox.test.tsx.snap @@ -49,6 +49,7 @@ exports[`MessageBox Confirm - Cancel 1`] = ` Confirm - Cancel @@ -105,6 +106,7 @@ exports[`MessageBox Confirm - OK 1`] = ` Confirm - OK @@ -152,6 +154,7 @@ exports[`MessageBox Error 1`] = ` Error @@ -199,6 +202,7 @@ exports[`MessageBox Information 1`] = ` Information @@ -255,6 +259,7 @@ exports[`MessageBox No Title 1`] = ` No Title @@ -302,6 +307,7 @@ exports[`MessageBox Not open 1`] = ` Custom Success @@ -357,6 +363,7 @@ exports[`MessageBox Show 1`] = ` Custom @@ -404,6 +411,7 @@ exports[`MessageBox Success 1`] = ` Success @@ -451,6 +459,7 @@ exports[`MessageBox Success w/ custom title 1`] = ` Custom Success @@ -498,6 +507,7 @@ exports[`MessageBox Warning 1`] = ` Warning diff --git a/packages/main/src/components/Notification/__snapshots__/Notification.test.tsx.snap b/packages/main/src/components/Notification/__snapshots__/Notification.test.tsx.snap index e9c33899561..9f48f8992c3 100644 --- a/packages/main/src/components/Notification/__snapshots__/Notification.test.tsx.snap +++ b/packages/main/src/components/Notification/__snapshots__/Notification.test.tsx.snap @@ -36,6 +36,7 @@ exports[`Notification Default 1`] = ` >