fix: do not use assignedElements (#432)

SAP · May 23, 2019 · c54c812 · c54c812
1 parent e9550ce
commit c54c812
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/base/src/UI5Element.js b/packages/base/src/UI5Element.js
@@ -579,7 +579,7 @@ class UI5Element extends HTMLElement {
 			if (curr.tagName.toUpperCase() !== "SLOT") {
 				return acc.concat([curr]);
 			}
-			return acc.concat(curr.assignedElements({ flatten: true }));
+			return acc.concat(curr.assignedNodes({ flatten: true }).filter(item => item instanceof HTMLElement));
 		};
 
 		return this[slotName].reduce(reducer, []);

diff --git a/packages/base/src/UI5ElementMetadata.js b/packages/base/src/UI5ElementMetadata.js
@@ -97,7 +97,7 @@ const validateSingleSlot = (value, propData) => {
 		const isSlot = isTag && el.tagName.toUpperCase() === "SLOT";
 
 		if (isSlot) {
-			return el.assignedElements({ flatten: true });
+			return el.assignedNodes({ flatten: true }).filter(item => item instanceof HTMLElement);
 		}
 
 		return [el];