Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-color-picker): add simplified display mode #10153

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

didip1000
Copy link
Contributor

Introducing a new property displayMode for the ui5-color-picker allowing users to select between the default (classic) color picker or the new simplified color picker.

The simplified picker does not include the RGB inputs and alpha slider.

You can create a color picker in simplified mode as follows:

<ui5-color-picker display-mode="Simplified"></ui5-color-picker>

Which will look as follows:

image

Fixes: #9979

@didip1000 didip1000 self-assigned this Nov 6, 2024
Copy link
Contributor

@hinzzx hinzzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor comments, after they are being addressed the change looks good to me.

packages/main/src/ColorPicker.hbs Outdated Show resolved Hide resolved
packages/main/src/ColorPicker.ts Outdated Show resolved Hide resolved
@didip1000 didip1000 marked this pull request as ready for review November 13, 2024 12:51
@didip1000 didip1000 merged commit bf9c0d6 into main Nov 14, 2024
10 checks passed
@didip1000 didip1000 deleted the colorpicker-simplified branch November 14, 2024 07:51
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.5.0-rc.0 🎉

The release is available on v2.5.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: ui5-color-picker option to disable transparency
5 participants