-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-color-picker): add simplified display mode #10153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDafov
approved these changes
Nov 7, 2024
hinzzx
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few minor comments, after they are being addressed the change looks good to me.
hinzzx
approved these changes
Nov 11, 2024
tsanislavgatev
requested changes
Nov 13, 2024
tsanislavgatev
approved these changes
Nov 14, 2024
🎉 This PR is included in version v2.5.0-rc.0 🎉 The release is available on v2.5.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new property
displayMode
for theui5-color-picker
allowing users to select between thedefault
(classic) color picker or the newsimplified
color picker.The simplified picker does not include the RGB inputs and alpha slider.
You can create a color picker in simplified mode as follows:
Which will look as follows:
Fixes: #9979