fix(ui5-menu): provide a way to focus items on fetch #10210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
reviewed
Nov 28, 2024
packages/website/docs/_samples/main/Menu/DynamicallyAddedItems/main.js
Outdated
Show resolved
Hide resolved
packages/website/docs/_samples/main/Menu/DynamicallyAddedItems/sample.html
Outdated
Show resolved
Hide resolved
packages/website/docs/_samples/main/Menu/DynamicallyAddedItems/main.js
Outdated
Show resolved
Hide resolved
|
Still need to add test. |
nnaydenow
reviewed
Dec 2, 2024
nnaydenow
approved these changes
Dec 4, 2024
|
🎉 This PR is included in version v2.5.0-rc.3 🎉 The release is available on v2.5.0-rc.3 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now provide an option to set the focus to the first item when a menu is opened.
To achieve that you have to call the focus method of either the Menu or MenuItem parenting the menu you're opening.
How To can be seen in the sample we're adding.
fixes: #7237