fix(ui5-popover): fix opener reference #10507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
approved these changes
Jan 13, 2025
ilhan007
added a commit
that referenced
this pull request
Jan 13, 2025
Previously the Popover's code assumed that if the opener is an UI5Element, then the DOM ref of the opener is the result of the `getFocusDomRef` method, which is not always the case. With this change, the popover will use the getFocusDomRef oof the opener, only if the opener is abstract UI5Element, with no effect on the rest of the cases.
|
🎉 This PR is included in version v2.7.0-rc.0 🎉 The release is available on v2.7.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Popover's code assumed that if the opener is an UI5Element, then the DOM ref of the opener is the result of the
getFocusDomRefmethod, which is not always the case.There are also noticeable misalignments of the popover that are caused by this fact. For example here the popover is shifted as it's aligned with the inner input (the focus dom ref):
With this change, the popover will use the getFocusDomRef oof the opener, only if the opener is abstract UI5Element,
with no effect on the rest of the cases.