Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-textarea): add "valueStateMessage" slot #1419

Merged
merged 7 commits into from
Apr 3, 2020
Merged

feat(ui5-textarea): add "valueStateMessage" slot #1419

merged 7 commits into from
Apr 3, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Apr 2, 2020 •
edited
Loading

  • add "valueStateMessage" slot
  • rename "valueStateMessage" CSS classes from "ui5-input-valuestatemessage-success" to "ui5-valuestatemessage--success", because they should not belong to the input only and ad two dashes to show modification (by the BEM notation)
  • there is code duplication at places with the code that handles the valueStateMessage in Input,
    but also differences related to the fact that the TextArea has no suggestions and has this "exceeding" (like Warning) state.

FIXES: #1401

@ilhan007 ilhan007 merged commit d323d51 into master Apr 3, 2020
@ilhan007 ilhan007 deleted the feat-textarea-valueStateMsg branch April 3, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-textarea: ValueState and ValueStateMessage support in TextArea component
2 participants
@ilhan007 @vladitasev