Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hbs2ui5): enables 3 or more levels of inheritance with templates #1593

Merged
merged 1 commit into from
May 12, 2020

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented May 11, 2020

  • lookup for include statements in the hbs files used to be just
    one level above the class.

- lookup for include statements in the hbs files used to be just
one level above the class.
@MapTo0 MapTo0 requested a review from vladitasev May 11, 2020 12:30
@@ -11,7 +11,7 @@ const removeWhiteSpaces = (source) => {
const compileString = async (sInput, config) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove async and fix the code that uses it, but I don't mind.

@MapTo0 MapTo0 closed this May 11, 2020
@MapTo0 MapTo0 reopened this May 11, 2020
@MapTo0 MapTo0 closed this May 11, 2020
@MapTo0 MapTo0 reopened this May 11, 2020
@MapTo0 MapTo0 merged commit 2a426dd into master May 12, 2020
@MapTo0 MapTo0 deleted the hbs-inheritance branch May 12, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants