Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-togglebutton): vertically align icon in IE #1824

Merged
merged 1 commit into from
Jun 17, 2020
Merged

fix(ui5-togglebutton): vertically align icon in IE #1824

merged 1 commit into from
Jun 17, 2020

Conversation

fifoosid
Copy link
Contributor

Related to #1815

vladitasev
vladitasev requested changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
just do the same for toggle button please, seems to have the same thing:

ui5-togglebutton ui5-icon.ui5-button-icon {
	height: 1rem;
	top: 0;
}```

@fifoosid fifoosid merged commit 2d5e84b into master Jun 17, 2020
@fifoosid fifoosid deleted the togglebutton-icon branch June 17, 2020 13:08
fifoosid added a commit that referenced this pull request Jun 22, 2020
@fifoosid
fix(ui5-togglebutton): vertically align icon in IE (#1824)
65422e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fifoosid @vladitasev @ilhan007