-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-progress-indicator): init implementation #1887
Conversation
feat(ui5-progress-indicator): add accessibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add demokit sample.
Add the component here: packages/playground/_site/build-scripts/samples-prepare.js
to get the "new" label in playground.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some several icons displayed in HCB when value state is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the test
- create method to get the validated value
const getValidatedValue = (pi) => {
return browser.execute((pi) => {
return pi.validatedValue;
}, pi);
};
- use in the asserts
validButton.click();
assert.strictEqual(getValidatedValue(progressIndicator), 50, “The value is validated correctly.“);
Fixes: #1392