feat(ui5-popup): add support for aria-label #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
aria-labelsupport forui5-popup. The implementation inui5-popoverandui5-dialogis:aria-label, use it and do not setaria-labelledbyin the shadow root (as it is stronger and will suppressaria-label)aria-labelledbynormally (to point to the id of the popup's header).Third-party popups will have full freedom to determine when
aria-labelandaria-labelledbyare set by overriding the protected methods, as before.In addition, added the missing description for
ariaLabelforui5-input.closes: #1896