Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui5-tabcontainer a11y issue. #1977

Closed
lateefsofi opened this issue Jul 23, 2020 · 0 comments · Fixed by #1978
Closed

Ui5-tabcontainer a11y issue. #1977

lateefsofi opened this issue Jul 23, 2020 · 0 comments · Fixed by #1978
Assignees
@fifoosid
Labels
ACC SAP SF SF_ACC

Comments

@lateefsofi
Copy link

Describe the bug
We use Axe for testing our components. We have implemented ui4-tabcontainer in ReactJs and we get accessibility issues for a button "Buttons must have discernible text".

To reproduce
Steps to reproduce the behavior:

  1. Go to http://mshaik.ies.c.na-us-1.cloud.sap:3001/hp-blended-item/COURSE/1591207334000
  2. You should have axe chrome tool installed
  3. Turn the screen into responsive mode(Mobile).
  4. Open dev tools, then go to Axe and Click Analyze.
  5. You should be able to see the issue "Buttons must have discernible text"

Expected behavior
Add aria-label or aria-labelledby attribute so that there is no a11y violation.

Screenshots
image

Context

  • UI5 Web Components version: "@ui5/webcomponents": "0.21.7",
  • OS/Platform: Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fifoosid fifoosid

Labels
ACC SAP SF SF_ACC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-tabcontainer): fix accessibility of overflow button SAP/ui5-webcomponents
4 participants
@vladitasev @fifoosid @nikolay-kolarov @lateefsofi