feat(ui5-multi-combobox): introduces filter property #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buildin filters are - StartsWithPerTerm - StartsWith - Contains - None FIXES: #799
vladitasev
requested changes
Aug 19, 2020
| * @defaultvalue "StartsWithPerTerm" | ||
| * @public | ||
| */ | ||
| filter: { |
There was a problem hiding this comment.
This should not be string, but an enum
There was a problem hiding this comment.
MultiComboBox has not really a use case for e.g. contains filter, for the end user the API works fine (the same way as an enum), we can discuss this internally if it is worth to be changed.
| StartsWithPerTerm, | ||
| StartsWith, | ||
| Contains, | ||
| None, |
There was a problem hiding this comment.
Is there a real use-case for this filter?
There was a problem hiding this comment.
In case the user wants to have a free text without filtering or implement filtering on the backend this would be a solution.
vladitasev
previously approved these changes
Sep 24, 2020
|
FIXES: #1735 |
vladitasev
approved these changes
Nov 17, 2020
ndeshev
pushed a commit
to ndeshev/ui5-webcomponents
that referenced
this pull request
Nov 18, 2020
Build-in filters are - StartsWithPerTerm - StartsWith - Contains - None Users can now set filter to None and filter when input event is fired FIXES: SAP#799
ilhan007
pushed a commit
that referenced
this pull request
Nov 19, 2020
Build-in filters are - StartsWithPerTerm - StartsWith - Contains - None Users can now set filter to None and filter when input event is fired FIXES: #799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Available filters are
FIXES: #799