Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-page): correct background-design styles #2862

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Feb 23, 2021

The styles used to rely on the property name backgroundDesign, which is not correct as in the DOM we use the attribute name background-design.
In addition, the "Standard" background design is removed, because it's the same as "Solid".
As a result the background Design default value is changed from "Standard" to "Solid".

@ilhan007 ilhan007 requested a review from MapTo0 March 2, 2021 08:22
@ilhan007 ilhan007 merged commit b10ee4c into master Mar 2, 2021
@ilhan007 ilhan007 deleted the fix-page-bgdesign branch March 2, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants