fix(ui5-daterange-picker): working with format pattern containing the delimiter #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested changes
Feb 26, 2021
|
Looks good to me. |
vladitasev
requested changes
Mar 5, 2021
packages/main/src/DateRangePicker.js
Outdated
| if (this.getFormat().oFormatOptions.pattern.indexOf(this._effectiveDelimiter) >= 0) { | ||
| const midIndex = Math.round(value.length / 2); | ||
|
|
||
| valuesArray[0] = value.slice(0, midIndex).split(this._effectiveDelimiter).join("").trim(); |
There was a problem hiding this comment.
.split(this._effectiveDelimiter).join("") -> this will remove all "-"s from the first part
same for the second part
Try running the function with "2020/01/01 - 2021/02/02" f.e.
You'll end up with "20200101" and "20210202" respectively.
IMO just get the mid index, everything from 0 to midIndex - 1 is the first part, and after mid index the second.
There was a problem hiding this comment.
This is done, because "2020/01/01 -" can't be formatted with our formatter, but 20200101 can. That's why i am removing the symbols that are breaking the formatting.
vladitasev
requested changes
Mar 12, 2021
vladitasev
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2851