-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-li-custom): enable setting height of the custom content #311
Conversation
@@ -15,14 +15,22 @@ ui5-li-custom .sap-phone .sapMLIB { | |||
} | |||
|
|||
.sapMLIB.sapMCustomLI { | |||
height: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go for height: 100%, because that way the bottom border will fall to the end of the list item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will revisit it once again, as Martin also suggested that providing min-height makes it not 100% custom (someone may want to set smaller height) and I will consider this comment as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought about this case, but it becomes very difficult to handle, because the list can be SingleSelection or MultiSelection, which contains RadioButton or Checkbox, which are going to be cut.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
valid point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go for height: 100%, because that way the bottom border will fall to the end of the list item
Applied with the latest commit.
Provide min-height and height: auto to the custom list item, so the consumers can set a custom height to their content.
Fixes: #310