Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-li-custom): enable setting height of the custom content #311

Merged
merged 4 commits into from
Apr 9, 2019

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Apr 5, 2019

Provide min-height and height: auto to the custom list item, so the consumers can set a custom height to their content.
Fixes: #310

@ilhan007 ilhan007 requested a review from fifoosid April 5, 2019 13:27
@@ -15,14 +15,22 @@ ui5-li-custom .sap-phone .sapMLIB {
}

.sapMLIB.sapMCustomLI {
height: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go for height: 100%, because that way the bottom border will fall to the end of the list item

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revisit it once again, as Martin also suggested that providing min-height makes it not 100% custom (someone may want to set smaller height) and I will consider this comment as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thought about this case, but it becomes very difficult to handle, because the list can be SingleSelection or MultiSelection, which contains RadioButton or Checkbox, which are going to be cut.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go for height: 100%, because that way the bottom border will fall to the end of the list item

Applied with the latest commit.

@ilhan007 ilhan007 requested a review from fifoosid April 8, 2019 14:04
@ilhan007 ilhan007 merged commit 76bf9f3 into master Apr 9, 2019
@ilhan007 ilhan007 deleted the refactor-custom-li-height branch April 9, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants