Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): support sap-* config URL params #3138

Merged
merged 4 commits into from
Apr 21, 2021
Merged

feat(framework): support sap-* config URL params #3138

merged 4 commits into from
Apr 21, 2021

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Apr 13, 2021

The change will assist broader UI technology co-existence by allowing the app developers use the older sap-* params in order to configure the theme, language, etc. There are use-cases where the sap-* is still the preferred param.
In case both sap-ui-* and sap-* params are set, the sap-ui-* ones will take precedence - the same way UI5 handles it.

FIXES: #3114

@ilhan007 ilhan007 requested a review from vladitasev April 13, 2021 09:21
@ilhan007 ilhan007 changed the title feat: support sap-* config URL params feat(framework): support sap-* config URL params Apr 13, 2021
@ilhan007 ilhan007 requested review from fifoosid and pskelin April 13, 2021 13:47
@ilhan007
Copy link
Member Author

Thanks for the hash update, I forgot it

@ilhan007 ilhan007 merged commit 5d9cdb9 into master Apr 21, 2021
@ilhan007 ilhan007 deleted the config branch April 21, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for "sap-theme" URL parameter
2 participants