Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-button): introducing attention type button #3481

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

tsanislavgatev
Copy link
Contributor

fixes: #3446

@ilhan007
Copy link
Member

ilhan007 commented Jul 1, 2021

Hi @tsanislavgatev I saw that "Attention" type is added, the issue mentions also the "Critical" type, is there a reason not to add it or it's planned for different change later on

@tsanislavgatev
Copy link
Contributor Author

Hi @ilhan007,
I am not aware of Critical type implementation planned.
But as far as i can see is Critical / Attention which I understand as one of them. And in the explanation given by Marcus it's stated that they need a Warning type of button in brackets asked for one of them both.

@ilhan007
Copy link
Member

ilhan007 commented Jul 2, 2021

Looks good to me @SAP/ui5-webcomponents-topic-b to still review

@ilhan007 ilhan007 requested a review from a team July 2, 2021 09:36
@MarcusNotheis
Copy link
Collaborator

Hi @ilhan007,
I am not aware of Critical type implementation planned.
But as far as i can see is Critical / Attention which I understand as one of them. And in the explanation given by Marcus it's stated that they need a Warning type of button in brackets asked for one of them both.

Yes, the Attention Design is totally sufficient for me :) I was just not sure which name you would prefer in your implementation so I listed both options that are used in UI5 🙂

@tsanislavgatev tsanislavgatev merged commit 2c9393c into master Jul 8, 2021
@tsanislavgatev tsanislavgatev deleted the new-button-type branch July 8, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-button: add Critical/Attention design
4 participants