You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of the Release Testing, I found that issue but later on, when implementing SAP Horizon theme, I realised that we have to adjust the whole implementation of the control.
Currently, ui5-rating-indicator icons are rendered as Unicode Symbols - “★” and “☆” and that causes many issues in the components styling.
We should investigate, whether we could change the implementation of the icons using the icon’s font respectively corresponding SVG icons in the Web Components.
Then we should check the visual specification for each supported theme and implement everything which is currently missing.
As a result of the current implementation, the icon size is controlled via font-size. Since, changing the implementation, will change that as well, the current issue should be also resolved with the created BLI.
After changing the implementation, the components documentation should be revised as well, because it is written: “You can change the size of the Rating Indicator by changing its font-size CSS property.
Example: ” that would not be valid anymore.
We can thing about adding similar property to openUI5 “iconSize” if we want to give a way for controlling icons size.
Bug Description
The default icon's size in compact mode is the same as in cozy mode - 1.5rem
Expected Behavior
According to the specification, the default icon's size in compact mode should be 1rem.
Steps to Reproduce
The text was updated successfully, but these errors were encountered: