Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating Indicator: Default icon size in compact mode is wrong #3724

Closed
niyap opened this issue Aug 25, 2021 · 1 comment · Fixed by #5191
Closed

Rating Indicator: Default icon size in compact mode is wrong #3724

niyap opened this issue Aug 25, 2021 · 1 comment · Fixed by #5191

Comments

@niyap
Copy link
Contributor

niyap commented Aug 25, 2021

Bug Description

The default icon's size in compact mode is the same as in cozy mode - 1.5rem

Expected Behavior

According to the specification, the default icon's size in compact mode should be 1rem.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/main/pages/RatingIndicator/
  2. Add style class ui5-content-density-compact to a sample where default size is used.
  3. Check the font-size applied
@niyap
Copy link
Contributor Author

niyap commented Dec 6, 2021

Hello Colleagues,

As part of the Release Testing, I found that issue but later on, when implementing SAP Horizon theme, I realised that we have to adjust the whole implementation of the control.
Currently, ui5-rating-indicator icons are rendered as Unicode Symbols - “★” and “☆” and that causes many issues in the components styling.

We should investigate, whether we could change the implementation of the icons using the icon’s font respectively corresponding SVG icons in the Web Components.
Then we should check the visual specification for each supported theme and implement everything which is currently missing.
As a result of the current implementation, the icon size is controlled via font-size. Since, changing the implementation, will change that as well, the current issue should be also resolved with the created BLI.
After changing the implementation, the components documentation should be revised as well, because it is written:
“You can change the size of the Rating Indicator by changing its font-size CSS property.
Example: ”
that would not be valid anymore.
We can thing about adding similar property to openUI5 “iconSize” if we want to give a way for controlling icons size.

Kind Regards,
Niya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

1 participant