fix(ui5-radio-button): exploratory testing issues #3740
Conversation
| @@ -10,6 +10,8 @@ | |||
| text-overflow: ellipsis; | |||
| overflow: hidden; | |||
| color: var(--sapField_BorderColor); | |||
| cursor: pointer; | |||
| width: fit-content; | |||
There was a problem hiding this comment.
Would the "fit-content" work for IE, I think it's not supported
There was a problem hiding this comment.
Try display: flex on the host element, instead of this.
There was a problem hiding this comment.
The commit message is unclear at what this commit does. Can you rewrite it?
The tag name is for the component is "ui5-radio-button".
The referenced issue also has an extra point about adding a sample for "readonly", so if you intend to make a seperate pull request for that, rewrite this PR to not have "Fixes #issueno" because merging it will close that issue.
packages/main/src/RadioButton.hbs
Outdated
| @@ -15,7 +15,7 @@ | |||
| <div class='ui5-radio-inner {{classes.inner}}'> | |||
| <svg class="ui5-radio-svg" focusable="false" aria-hidden="true"> | |||
| <circle class="ui5-radio-svg-outer" cx="50%" cy="50%" r="50%" /> | |||
| <circle class="ui5-radio-svg-inner" cx="50%" cy="50%" r="22%" /> | |||
| <circle class="ui5-radio-svg-inner" cx="50%" cy="50%" r="25%" stroke-width="10"/> | |||
There was a problem hiding this comment.
25% makes the "inner" blue dot grow to 11px.
The dot is specified to be 10px.
I also don't see any difference with stroke-width="10" and without it. Why is it needed?
If it is necessary, it could be part of the CSS.
| @@ -10,6 +10,8 @@ | |||
| text-overflow: ellipsis; | |||
| overflow: hidden; | |||
| color: var(--sapField_BorderColor); | |||
| cursor: pointer; | |||
| width: fit-content; | |||
There was a problem hiding this comment.
Try display: flex on the host element, instead of this.
Added readonly samples, width: fit-content replaced with display:flex
kskondov
changed the title
kskondov
changed the title
kskondov
requested review from
georgimkv,
TeodorTaushanov,
ilhan007 and
a team
The cursor should be a pointer
There should be a readonly sample
The width should be correct when focus is on the radio-button
Fixes: #3622