Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-popover): Arrow is placed correctly when some border is reached #3821

Merged
merged 3 commits into from
Sep 10, 2021
Merged

fix(ui5-popover): Arrow is placed correctly when some border is reached #3821

merged 3 commits into from
Sep 10, 2021

Conversation

TeodorTaushanov
Copy link
Member

Fixes: #3391

georgimkv
georgimkv previously requested changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@georgimkv georgimkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you just need to resolve the merge conflicts: Popover.MIN_OFFSET was renamed to Popover.VIEWPORT_MARGIN.

@ilhan007 ilhan007 merged commit 9913632 into master Sep 10, 2021
@ilhan007 ilhan007 deleted the PopoverOffset branch September 10, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgimkv georgimkv georgimkv approved these changes

@ilhan007 ilhan007 ilhan007 approved these changes

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong arrow position in Popover component
3 participants
@TeodorTaushanov @ilhan007 @georgimkv