Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-multi-combobox): Fix value reset on ESC #3958

Merged
merged 8 commits into from
Sep 27, 2021
Merged

fix(ui5-multi-combobox): Fix value reset on ESC #3958

merged 8 commits into from
Sep 27, 2021

Conversation

ndeshev
Copy link
Contributor

@ndeshev ndeshev commented Sep 18, 2021

Issue #3784:

When the picker is closed the entered value is now cleared/reset to the initial one.

@ndeshev ndeshev requested a review from MapTo0 September 20, 2021 12:12
MapTo0
MapTo0 previously requested changes Sep 21, 2021
View reviewed changes
Copy link
Member

@MapTo0 MapTo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fixing value removal on focus out in as part of #3931. I would suggest we merge my PR first then go with that one. Overall looks OK

@ndeshev ndeshev requested a review from MapTo0 September 21, 2021 15:29
@ndeshev ndeshev merged commit ed128db into SAP:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MapTo0 MapTo0 MapTo0 approved these changes

@niyap niyap Awaiting requested review from niyap

@elenastoyanovaa elenastoyanovaa Awaiting requested review from elenastoyanovaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndeshev @MapTo0