fix(ui5-rating-indicator): Apply correct color for readonly unselec… #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
previously requested changes
Sep 24, 2021
packages/main/src/RatingIndicator.js
Outdated
| @@ -207,6 +207,7 @@ class RatingIndicator extends UI5Element { | |||
| selected: i <= tempValue, | |||
| index: i, | |||
| halfStar, | |||
| readonly: this.readonly, | |||
There was a problem hiding this comment.
This will have the same value for all items. You don't need to push it here in order to access it in the .hbs file. Use the ../ syntax
| @@ -23,6 +23,8 @@ | |||
| <div class="ui5-rating-indicator-icon ui5-rating-indicator-active-icon" data-value="{{this.index}}">★</div> | |||
| {{else if this.halfStar}} | |||
| <div class="ui5-rating-indicator-icon ui5-rating-indicator-half-icon" data-value="{{this.index}}">☆</div> | |||
| {{else if this.readonly}} | |||
There was a problem hiding this comment.
See for example this snippet on how to use a global value:
{{#each items}}
{{#if this.selected}}
<ui5-token
?readonly="{{../readonly}}"
class="ui5-multi-combobox-token"
data-ui5-id="{{this._id}}"
part="token-{{@index}}"
text="{{this.text}}"
>
</ui5-token>
{{/if}}
{{/each}}
```
vladitasev
changed the title
ndeshev
approved these changes
Sep 27, 2021
fifoosid
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #3716