Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-input, ui5-date-picker): implement sap_horizon theme #4006

Merged
merged 9 commits into from
Oct 4, 2021

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Sep 27, 2021

Input:
image

DatePicker:
image

Open questions

  • Popups(value state message, suggestions) look really strange since the input now has round borders

Fixes: #4040
Fixes: #4046

@d3xter666
Copy link
Contributor

Hi @fifoosid ,

There are several issues which might need to be adjusted.

  • The glow/shadow of warning, error, etc. has a color. The grey is for the default state
  • When you hover on input the bottom border is shifted a bit, so there's a 1px of white below
  • The border of the active state of (Multi)ComboBox is a bit broken on the edges/rounded corners.

Screenshot 2021-10-01 at 14 47 17

Screenshot 2021-10-01 at 14 42 23

P.S. Considering list (items) in the ComboBox, SuggestionsPopover, etc., as well as Popover, is not in the scope of this change

Cheers

@fifoosid
Copy link
Contributor Author

fifoosid commented Oct 1, 2021

Hi @fifoosid ,

There are several issues which might need to be adjusted.

  • The glow/shadow of warning, error, etc. has a color. The grey is for the default state
  • When you hover on input the bottom border is shifted a bit, so there's a 1px of white below
  • The border of the active state of (Multi)ComboBox is a bit broken on the edges/rounded corners.
Screenshot 2021-10-01 at 14 47 17 Screenshot 2021-10-01 at 14 42 23

P.S. Considering list (items) in the ComboBox, SuggestionsPopover, etc., as well as Popover, is not in the scope of this change

Cheers

Yes, changes related to Popover(already merged) and ListItem will not be part of this change

d3xter666
d3xter666 previously approved these changes Oct 4, 2021
@ilhan007 ilhan007 merged commit e137de3 into master Oct 4, 2021
@ilhan007 ilhan007 deleted the input-sap-horizon branch October 4, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants