feat(ui5-input, ui5-combobox, ui5-multicombobox): SAP Horizon Theme Implementation #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elenastoyanovaa
commented
Oct 26, 2021
•
elenastoyanovaa
commented
- Apply border radius to first and last item (value state header, group header or list item) in the suggestions popover in order to follow popover border radius design
- Set focused property at the same time as the selected property of InputSuggestions, since the "fake" focus moves with the selection. Previously, this led to no focus outline in suggestions items
- Update focus styles for value state header
- Reuse focus styling in suggestions for N-More
ndeshev
previously approved these changes
Oct 27, 2021
ndeshev
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.