Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-tabcontainer): paddings are changed according to the spec part 2 #4196

Merged
merged 4 commits into from
Nov 2, 2021
Merged

fix(ui-tabcontainer): paddings are changed according to the spec part 2 #4196

merged 4 commits into from
Nov 2, 2021

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Oct 27, 2021 •
edited
Loading

Fixed:

  • Tabs with icon
  • compact mode

Part of #2540

@TeodorTaushanov TeodorTaushanov requested a review from a team October 27, 2021 12:10
@TeodorTaushanov TeodorTaushanov requested review from dimovpetar and a team November 2, 2021 12:45
@TeodorTaushanov TeodorTaushanov dismissed dimovpetar’s stale review November 2, 2021 12:47

Without this, the compact header height when there are icons is not correct.

@ilhan007 ilhan007 merged commit 3fd8b48 into master Nov 2, 2021
@ilhan007 ilhan007 deleted the TabContainerPaddings2 branch November 2, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimovpetar dimovpetar dimovpetar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeodorTaushanov @dimovpetar @ilhan007