fix(ui5-date-picker): enable date value strict parsing #4428
Conversation
| @@ -223,7 +223,7 @@ describe("Date Picker Tests", () => { | |||
| const valueHelpIcon = await datepicker.getValueHelpIcon(); | |||
| await valueHelpIcon.click(); | |||
|
|
|||
| let calendarDate_4_Jan_2019 = await datepicker.getPickerDate(1546560000); //Jan 4, 2019 | |||
| let calendarDate_4_Jan_2019 = await datepicker.getPickerDate(1638576000); //Jan 4, 2019 | |||
| await calendarDate_4_Jan_2019.click(); | |||
|
|
|||
| const innerInput = await datepicker.getInnerInput(); | |||
There was a problem hiding this comment.
I do not understand that part, the date is different now, but the input stays the same.
If the date is different, please change the comments and variable names also.
There was a problem hiding this comment.
I've disabled the failing timezone test as it works based on a faked Date.prototype.getDate method.
That way a DateFormat instance with strict parsing enabled is unable to parse the value strings from the input field.
I would suggest to address this test issue in another change.
There was a problem hiding this comment.
@unazko In case you don't plan to immediately fix it with another change. please create an issue for that not to forget it. If you plan to immediately address it, a new issue is not required.
There was a problem hiding this comment.
Additional investigation time would be required, in order to adjust the described test properly.
I've created the following issue in this regard: #4443
|
Could you provide perhaps one sentence what the fix does and we can merge it. and perhaps you can elaborate a bit - strict parsing of what Think this way, someone will read the release notes, and by the title of the commit should be able more or less to understand what the change is doing. |
unazko
changed the title
unazko
changed the title
A validity check is now performed while parsing the date value. Fixes: SAP#4409
A validity check is now performed while parsing the date value.
Fixes: #4409