fix(ui5-file-uploader): fixing the console warning #4605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
reviewed
Jan 24, 2022
| @@ -9,7 +9,9 @@ | |||
| horizontal-align="Left" | |||
| > | |||
| <div slot="header" class="{{classes.popoverValueState}}" style="{{styles.popoverHeader}}"> | |||
| <ui5-icon class="ui5-input-value-state-message-icon" name="{{_valueStateMessageInputIcon}}"></ui5-icon> | |||
| {{#if _valueStateMessageInputIcon}} | |||
There was a problem hiding this comment.
This private method has wrong code documentation. It is not only relevant for the horizon theme so it seems.
There was a problem hiding this comment.
Yes, It doesn't work only on horizon theme, but the difference made from the result can be observed only on horizon theme, as the value state icon is only visible on the horizon theme. So it is and it is not at the same time.
unazko
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4592