feat(popups): Implement declarative API for open/close #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
reviewed
Jan 31, 2022
| /** | ||
| * Defines the opener id of the element that the popover is shown at | ||
| * @public | ||
| * @type {String} |
ilhan007
reviewed
Jan 31, 2022
| @@ -60,12 +60,23 @@ const metadata = { | |||
|
|
|||
| /** | |||
| * Indicates if the element is open | |||
| * @public | |||
| * @type {boolean} | |||
georgimkv
previously requested changes
Feb 1, 2022
ilhan007
previously requested changes
Feb 3, 2022
There was a problem hiding this comment.
Overall it seems fine, could you just check one more thing - Responsive Popover in the mobile case (opens as a Dialog), locally it blinks for me - opens and closes immediately. To test it - just click the first button on the test page http://localhost:8080/test-resources/pages/ResponsivePopover.html
|
Hello @TeodorTaushanov the change seems almost ready, there are just few comments left. Do you need any support from our side? |
TeodorTaushanov
requested review from
ilhan007 and
a team
and removed request for
ilhan007
georgimkv
approved these changes
Feb 18, 2022
ilhan007
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3527