Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-tabcontainer): fix overflow button runtime error #4780

Merged
merged 6 commits into from
Feb 18, 2022

Conversation

kskondov
Copy link
Contributor

Runtime error is no longer thrown when custom overflow buttons are used via slots
FIXES: #4770

Runtime error is no longer thrown when custom overflow buttons are used via slots
FIXES: #4770
ilhan007
ilhan007 previously approved these changes Feb 18, 2022
@ilhan007 ilhan007 requested a review from georgimkv February 18, 2022 12:28
Copy link
Contributor

@georgimkv georgimkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a test for this issue?

@kskondov
Copy link
Contributor Author

Done

@ilhan007 ilhan007 merged commit 08d75fa into master Feb 18, 2022
@ilhan007 ilhan007 deleted the ui5-tabcontainer-overflowSlot branch February 18, 2022 14:45
ilhan007 pushed a commit that referenced this pull request Mar 18, 2022
Runtime error is no longer thrown when custom overflow buttons are used via slots

FIXES: #4770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SF][1.1.2][ui5-tabcontainer]: slot overflowButton will get runtime error
3 participants