feat(ui5-input): implement type ahead (autocomplete) #5211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add property, refactor filters
MapTo0
reviewed
May 23, 2022
packages/main/src/Filters.js
Outdated
| @@ -6,7 +6,8 @@ const escapeRegExp = str => { | |||
|
|
|||
| const StartsWith = (value, items) => { | |||
| return items.filter(item => { | |||
| const lowerText = item.text.toLowerCase(); | |||
| const text = item.text || item.textContent; | |||
There was a problem hiding this comment.
what happens if a new poperty pops up next week, should we add another || ? Can we add the propName as parameter to the filter function? not big deal, just an idea
packages/main/src/Input.js
Outdated
| * @public | ||
| * @since 1.4.0 | ||
| */ | ||
| disableAutocomplete: { |
There was a problem hiding this comment.
dont like that naming @ilhan007 ideas? :D
refactor filters to be used by all input components
ndeshev
force-pushed
the
input-typeahead
branch
2 times, most recently
from
1a45258 to
6f3da3a
Compare
retrigger tests
MapTo0
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request: #3488