feat(ui5-rating-indicator): implement small icons for readonly and disabled #5233
Conversation
There was a problem hiding this comment.
The big star is somehow misaligned. It is not aligned in the middle. Perhaps it is an ui5-icon issue, but I saw that we also have some additional stylings for the icon. You could ignore this comment, as it has nothing to do with your change (I think) but I wanted to make you aware of this issue as you previously implemented the horizon theme for the rating indicator.
| :root { | ||
| --_ui5_rating_indicator_border_radius: 0.25rem; | ||
| --_ui5_rating_indicator_readonly_item_height: 0.75em; | ||
| --_ui5_rating_indicator_readonly_item_width: 0.75em; | ||
| --_ui5_rating_indicator_readonly_item_spacing: 3px 3px; |
There was a problem hiding this comment.
Could you please use rem instead for the spacing in order to be consistent and aligned with the spec?
There was a problem hiding this comment.
I did it on purpose, because 0.188rem is hard to guess, but can change it if you insist.
There was a problem hiding this comment.
Actually it is 0.1875rem and it is widely used in this repo for setting sizes: https://github.com/SAP/ui5-webcomponents/search?q=0.1875rem
The same applies for 0.125rem (2px).
No description provided.