fix(ui5-dialog): add height to footer and samples achieving fiori footer design #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerganaKremenska
requested review from
TeodorTaushanov,
georgimkv,
dimovpetar and
BorisDafov
georgimkv
changed the title
BorisDafov
suggested changes
Jun 9, 2022
BorisDafov
suggested changes
Jun 14, 2022
| <ui5-dialog id="fiori-footer-dialog" header-text="Fiori footer buttons"> | ||
| <p>Adding custom styles to achieve the look and field of a Fiori footer</p> | ||
| <div slot="footer" style="display: flex; align-items: center; justify-content: end; width: 100%; box-sizing: border-box;"> | ||
| <ui5-button design="Emphasized" style="min-width: 4rem;">Ok</ui5-button> |
BorisDafov
previously approved these changes
Jun 16, 2022
dimovpetar
previously approved these changes
Jun 16, 2022
ilhan007
reviewed
Jun 20, 2022
GerganaKremenska
dismissed stale reviews from dimovpetar and BorisDafov
via
2f41433
georgimkv
previously requested changes
Jun 20, 2022
georgimkv
approved these changes
Jun 20, 2022
ilhan007
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5306