Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popup]: Clean up body style class on disconnect #592

Closed
MarcusNotheis opened this issue Jun 26, 2019 · 1 comment
Closed

[Popup]: Clean up body style class on disconnect #592

MarcusNotheis opened this issue Jun 26, 2019 · 1 comment
Assignees
Labels
approved This issue is approved bug This issue is a bug in the code

Comments

@MarcusNotheis
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When removing an open Popup with the modal property set or when removing an open Dialog from the DOM, the style class sapUiBLyBack is not removed from the body tag.
This is causing inconsistencies in our application.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Implement the disconnectedCallback of the Web Components lifecycle in order to clean up the style.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
None.

Additional context
Add any other context or screenshots about the feature request here.
Happy to submit a Pull Request if desired 😄

@fifoosid fifoosid self-assigned this Jun 26, 2019
@fifoosid fifoosid added approved This issue is approved bug This issue is a bug in the code labels Jun 26, 2019
@fifoosid
Copy link
Contributor

The issue was solved.

PS: Would like to hear feedback if the solution fits your use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is approved bug This issue is a bug in the code
Projects
None yet
Development

No branches or pull requests

2 participants