fix(framework): support older OpenUI5 getThemeRoot API #7202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
previously approved these changes
Jun 15, 2023
vladitasev
reviewed
Jun 15, 2023
vladitasev
approved these changes
Jun 15, 2023
nnaydenow
pushed a commit
that referenced
this pull request
Jun 15, 2023
Theming.getThemeRoot is recently added OpenUI5 API, but not released yet (available on nightly snapshot). To support currently released OpenUI5 versions we need to use the older API "Configuration#getThemeRoot". - Fetch Theming only for OpenUi5 versions since 1.116.0 and onward - For OpenUi5 versions prior to 1.116.0 use Configuration#getThemeRoot API - For the version processing, use the global util "sap/base/util/Version" Fixes: #7199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theming.getThemeRoot is recently added OpenUI5 API, but not released yet (available on nightly snapshot). To support currently released OpenUI5 versions we need to use the older API "Configuration#getThemeRoot".
Fixes: #7199