Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-table popin-change event not fired when columns pop out #7620

Closed
1 task done
vladitasev opened this issue Sep 25, 2023 · 2 comments · Fixed by #7837
Closed
1 task done

ui5-table popin-change event not fired when columns pop out #7620

vladitasev opened this issue Sep 25, 2023 · 2 comments · Fixed by #7837
Assignees
Milestone

Comments

@vladitasev
Copy link
Contributor

Bug Description

popin-change is not fired when columns pop out (only when they pop in).

Affected Component

ui5-table

Expected Behaviour

popin-change is fired when columns pop in or out.

Isolated Example

No response

Steps to Reproduce

Open the regular test page for Table: http://localhost:8080/packages/main/test/pages/Table.html
Shrink the browser, you'll see:
image

Then resize the browser back to normal: the input says the same (doesn't go back go "0 popped in columns"

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@vladitasev vladitasev added the bug This issue is a bug in the code label Sep 25, 2023
@elenastoyanovaa elenastoyanovaa self-assigned this Sep 25, 2023
@elenastoyanovaa
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rl ,

There seems to be an issue with the popin-change event. When there are no hidden column (imagine there were 2 popined columns and the table is resized to its original size and there are no popined columnd now) the popin change event is not fired.

The issue is in popinContent method:

	if (hiddenColumns.length) {
		this.fireEvent<TablePopinChangeEventDetail>("popin-change", {
			poppedColumns: this._hiddenColumns,
		});
	}

here when the table is restored to its size when there is no need of popin columns hiddenColumns becomes zero and the event is not fired, but it should be.

Please follow Vladi's description for steps to reproduce.

Kind Regards,
Elena

@ilhan007
Copy link
Member

ilhan007 commented Nov 3, 2023

Hello colleagues, just fyi we have also a stakeholder that reported this issue - SAP Build Process Automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants